<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Ohh, really I forgot, but our style checker does not seem to care, instead he falsely complains on the include order in WQtGui.cpp. I checkin the missing space, and open a ticket for style checker.<div class=""><br class=""></div><div class="">best-</div><div class="">Mathias </div><div class=""><div class=""><div style="margin: 0px; font-size: 14px; font-family: Menlo; color: rgb(83, 48, 225);" class=""><b class=""><br class=""></b></div><div><blockquote type="cite" class=""><div class="">Am 17.08.2015 um 14:24 schrieb Sebastian Eichelbaum <<a href="mailto:privat@sebastian-eichelbaum.de" class="">privat@sebastian-eichelbaum.de</a>>:</div><br class="Apple-interchange-newline"><div class="">Please also check style. It seems rightbuttonpush braces do not include a space.<br class=""><br class="">math <<a href="mailto:math@informatik.uni-leipzig.de" class="">math@informatik.uni-leipzig.de</a>> schrieb am 17.08.2015:<br class=""><blockquote type="cite" class="">*Branch OpenWalnut_1.4*<br class="">[CHANGE] boost::optional does not provide implicit casts, hence<br class="">explicit comparison is made for bool, to provide standard conformity to<br class="">c++11.<br class=""><br class="">changeset 7435:020c40921e37 in /srv/hg/ow (Mon Aug 17 14:21:30 2015<br class="">+0200):<br class=""><br class=""><a href="http://www.openwalnut.org/projects/openwalnut/repository/revisions/7435" class="">http://www.openwalnut.org/projects/openwalnut/repository/revisions/7435</a><br class=""><br class="">diffstat:<br class=""><br class="">src/modules/clusterDisplay/WMClusterDisplay.cpp <br class=""> | 2 +-<br class="">src/modules/hierarchicalClustering/hierchClustDisplay/WMHierchClustDisplay.cpp<br class="">| 4 ++--<br class="">2 files changed, 3 insertions(+), 3 deletions(-)<br class=""><br class="">diffs (29 lines):<br class=""><br class="">diff -r 9bfbba026df2 -r 020c40921e37<br class="">src/modules/clusterDisplay/WMClusterDisplay.cpp<br class="">--- a/src/modules/clusterDisplay/WMClusterDisplay.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>Mon Aug 17<br class="">10:46:54 2015 +0200<br class="">+++ b/src/modules/clusterDisplay/WMClusterDisplay.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>Mon Aug 17<br class="">14:21:30 2015 +0200<br class="">@@ -57,7 +57,7 @@<br class="">// wlog::debug( "WMClusterDisplay::MainViewEventHandler" ) <<<br class="">"handle";<br class="">if( ea.getEventType() == GUIEvents::PUSH && ea.getButton() ==<br class="">osgGA::GUIEventAdapter::LEFT_MOUSE_BUTTON )<br class=""> {<br class="">- return m_signalLeftButtonPush( WVector2f( ea.getX(), ea.getY()<br class="">) );<br class="">+ return ( true == m_signalLeftButtonPush( WVector2f( ea.getX(),<br class="">ea.getY() ) ) );<br class=""> }<br class=""> return false;<br class="">}<br class="">diff -r 9bfbba026df2 -r 020c40921e37<br class="">src/modules/hierarchicalClustering/hierchClustDisplay/WMHierchClustDisplay.cpp<br class="">---<br class="">a/src/modules/hierarchicalClustering/hierchClustDisplay/WMHierchClustDisplay.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>Mon<br class="">Aug 17 10:46:54 2015 +0200<br class="">+++<br class="">b/src/modules/hierarchicalClustering/hierchClustDisplay/WMHierchClustDisplay.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>Mon<br class="">Aug 17 14:21:30 2015 +0200<br class="">@@ -85,11 +85,11 @@<br class="">// wlog::debug( "WMHierchClustDisplay::MainViewEventHandler" ) <<<br class="">"handle";<br class="">if( ea.getEventType() == osgGA::GUIEventAdapter::PUSH && ea.getButton()<br class="">== osgGA::GUIEventAdapter::LEFT_MOUSE_BUTTON )<br class=""> {<br class="">- return m_signalLeftButtonPush( WVector2f( ea.getX(), ea.getY()<br class="">) );<br class="">+ return ( true == m_signalLeftButtonPush( WVector2f( ea.getX(),<br class="">ea.getY() ) ) );<br class=""> }<br class="">if( ea.getEventType() == osgGA::GUIEventAdapter::PUSH && ea.getButton()<br class="">== osgGA::GUIEventAdapter::RIGHT_MOUSE_BUTTON )<br class=""> {<br class="">- return m_signalRightButtonPush( WVector2f( ea.getX(),<br class="">ea.getY() ) );<br class="">+ return (true == m_signalRightButtonPush( WVector2f( ea.getX(),<br class="">ea.getY() ) ) );<br class=""> }<br class=""> return false;<br class="">}<br class="">_______________________________________________<br class="">All-openwalnut-commits mailing list<br class="">All-openwalnut-commits@lists.informatik.uni-leipzig.de<br class="">http://lists.informatik.uni-leipzig.de/mailman/listinfo/all-openwalnut-commits<br class=""></blockquote><br class="">_______________________________________________<br class="">OpenWalnut-Dev mailing list<br class=""><a href="mailto:OpenWalnut-Dev@lists.informatik.uni-leipzig.de" class="">OpenWalnut-Dev@lists.informatik.uni-leipzig.de</a><br class="">http://lists.informatik.uni-leipzig.de/mailman/listinfo/openwalnut-dev<br class=""><br class="">Archive: http://lists.informatik.uni-leipzig.de/pipermail/openwalnut-dev/<br class=""></div></blockquote></div><br class=""></div></div></body></html>